Stream: git-wasmtime

Topic: wasmtime / PR #5588 winch: Adding support for integration...

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:56):

KevinRizzoTO edited PR #5588 from winch-golden-tests to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [x] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

As discussed on our call, this PR adds support for integration tests to Winch in the style of the Cranelift filetests (for WAT). For information on how these work I've added documentation in the winch/docs folder here. There are still some features missing that we are going to add as we continue the project, like support for sending shared flags through the test configuration. Winch doesn't use these currently so it's been omitted to keep this PR smaller.

I also took this as an opportunity to consolidate some dependencies into the top level Cargo.toml. Some dependencies used by Cranelift were needed for the Winch tests, so I wanted to make sure the version would be consistent and consolidated to a single location.

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:58):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera created PR review comment:

We can use the workspace version of this dependency.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera created PR review comment:

    // Without this, all functions are seen as dead code since they are only used in tests.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera created PR review comment:

Would adding #[cfg(test)] above line 3 instead of this directive achieve the same result?

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera created PR review comment:

Equally applies to the comments below.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:19):

saulecabrera created PR review comment:

/// Generate a test case for every .wat file in the filetests directory.
/// This should only be used from the filetests crate.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:44):

KevinRizzoTO submitted PR review.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:44):

KevinRizzoTO created PR review comment:

Oh yes it did! Forgot to add this in, thanks

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:45):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 16:51):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 20:32):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 20:54):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 21:33):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 22:02):

KevinRizzoTO updated PR #5588 from winch-golden-tests to main.

Wasmtime GitHub notifications bot (Jan 19 2023 at 12:31):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 19 2023 at 12:34):

saulecabrera merged PR #5588.

Last updated: Dec 23 2024 at 13:07 UTC