jameysharp requested elliottt for a review on PR #5586.
jameysharp opened PR #5586 from use-count-iter
to main
:
This is a cleanup to help prepare for #5464.
Most of the diff is inlining the closure for
mark_all_uses_as_multiple
which was only called once. That avoids some borrow-checker challenges.The key change is that the former
push_args_on_stack
closure no longer actually pushes the iterator on the stack, but just returns it. That way this closure doesn't need the name of the stack's type. It also allows it to be reused in the debug_assert.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt submitted PR review.
jameysharp has enabled auto merge for PR #5586.
jameysharp merged PR #5586.
Last updated: Dec 23 2024 at 13:07 UTC