Stream: git-wasmtime

Topic: wasmtime / PR #5584 cranelift: Disable select rule for i1...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2023 at 16:24):

afonso360 opened PR #5584 from riscv64-fuzzgen-disable-select to main:

:wave: Hey

This PR disables one of the select rules for i128 values. This rule was enabled for all types, but only supports single register values.

It also disables i128 select from being generated. While in this case it did catch an actual issue, it is broken for fuzzgen (#5524) and it somehow got lost when updating #5502.

Fixes #5583

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2023 at 16:28):

afonso360 edited PR #5584 from riscv64-fuzzgen-disable-select to main:

:wave: Hey

This PR disables one of the select rules for i128 values. This rule was enabled for all types, but only supports single register values. gen_select_reg only supports Reg values and not ValueRegs.

It also disables i128 select from being generated. While in this case it did catch an actual issue, it is broken for fuzzgen (#5524) and it somehow got lost when updating #5502.

Fixes #5583

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2023 at 18:01):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2023 at 18:01):

fitzgen merged PR #5584.

Last updated: Oct 23 2024 at 20:03 UTC