Stream: git-wasmtime

Topic: wasmtime / PR #5571 `generated-code.rs` is not itself gen...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2023 at 18:27):

jameysharp requested fitzgen for a review on PR #5571.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2023 at 18:27):

jameysharp opened PR #5571 from gitattr-generated to main:

cranelift/codegen/src/isa/*/lower/isle/generated_code.rs are hand-written modules that include! the actual generated code.

Tagging these hand-written files as linguist-generated in .gitattributes tells GitHub not to show them in diffs by default. But they're actually important to review, so they should be included in diffs.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2023 at 19:03):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2023 at 19:03):

fitzgen merged PR #5571.

Last updated: Oct 23 2024 at 20:03 UTC