Stream: git-wasmtime

Topic: wasmtime / PR #5570 cranelift-codegen: Prepare aarch64 fo...

Wasmtime GitHub notifications bot (Jan 13 2023 at 17:00):

saulecabrera opened PR #5570 from expose-aarch64-pieces-for-codegen to main:

Similar to https://github.com/bytecodealliance/wasmtime/pull/5413
This commit exposes the necessary aarch64 pieces to be used by Winch for binary emission.

I defaulted to expose only the pieces that I'm anticipating that I'll need immediately; mainly the exports from the imms, args and settings modules. If there's a need for something else, I'll add it in a separate PR.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 13 2023 at 18:33):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 13 2023 at 18:33):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 13 2023 at 18:33):

jameysharp created PR review comment:

I think that once these are public outside the crate, the `#[allow(dead_code)] attribute becomes unnecessary. Could you try removing these attributes and verify that there aren't any warnings?

Wasmtime GitHub notifications bot (Jan 13 2023 at 18:33):

jameysharp created PR review comment:

Minor typo:

    /// Returns true if the VectorSize is 128-bits.

Wasmtime GitHub notifications bot (Jan 13 2023 at 18:33):

jameysharp created PR review comment:

Minor typo:

    /// Create a `MoveWideCosnt` from a given shift, if possible.

Wasmtime GitHub notifications bot (Jan 13 2023 at 19:05):

saulecabrera updated PR #5570 from expose-aarch64-pieces-for-codegen to main.

Wasmtime GitHub notifications bot (Jan 13 2023 at 19:06):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 13 2023 at 19:06):

saulecabrera created PR review comment:

Good catch! I removed the dead code warnings as suggested and no warnings came back.

Wasmtime GitHub notifications bot (Jan 13 2023 at 19:27):

jameysharp has enabled auto merge for PR #5570.

Wasmtime GitHub notifications bot (Jan 13 2023 at 19:46):

jameysharp merged PR #5570.

Last updated: Nov 22 2024 at 17:03 UTC