Stream: git-wasmtime

Topic: wasmtime / PR #5565 Update WIT tooling used by Wasmtime

Wasmtime GitHub notifications bot (Jan 12 2023 at 20:31):

alexcrichton opened PR #5565 from update-wasm-tools to main:

This commit updates the WIT tooling, namely the wasm-tools family of crates, with recent updates. Notably:

• bytecodealliance/wasm-tools#867
• bytecodealliance/wasm-tools#871

This updates index spaces in components and additionally bumps the minimum required version of the component binary format to be consumed by Wasmtime (because of the index space changes). Additionally WIT tooling now fully supports use.

Note that WIT tooling doesn't, at this time, fully support packages and depending on remotely defined WIT packages. Currently WIT still needs to be vendored in the project. It's hoped that future work with cargo component and possible integration here could make the story about depending on remotely-defined WIT more ergonomic and streamlined.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 12 2023 at 21:21):

alexcrichton updated PR #5565 from update-wasm-tools to main.

Wasmtime GitHub notifications bot (Jan 17 2023 at 21:15):

alexcrichton updated PR #5565 from update-wasm-tools to main.

Wasmtime GitHub notifications bot (Jan 17 2023 at 21:15):

alexcrichton has marked PR #5565 as ready for review.

Wasmtime GitHub notifications bot (Jan 17 2023 at 21:15):

alexcrichton requested peterhuene for a review on PR #5565.

Wasmtime GitHub notifications bot (Jan 17 2023 at 23:24):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jan 17 2023 at 23:24):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jan 17 2023 at 23:24):

peterhuene created PR review comment:

Should we add a TODO comment above explaining why these are commented out?

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:03):

alexcrichton updated PR #5565 from update-wasm-tools to main.

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:03):

alexcrichton created PR review comment:

Whoops thanks for catching I forgot to uncomment.

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:03):

alexcrichton has enabled auto merge for PR #5565.

Wasmtime GitHub notifications bot (Jan 18 2023 at 15:37):

alexcrichton merged PR #5565.

Last updated: Dec 23 2024 at 12:05 UTC