Stream: git-wasmtime

Topic: wasmtime / PR #5562 Treat `wasmtime::component::Val::Floa...

Wasmtime GitHub notifications bot (Jan 11 2023 at 22:59):

sunfishcode opened PR #5562 from sunfishcode/zero-equality to main:

Following up on #5535, treat positive and negative zero as inequal in wasmtime::component::Val::Float{32,64}'s PartialEq logic. IEEE 754 equality considers these values equal, but they are semantically distinct values, and testing and fuzzing should be aware of the difference.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 11 2023 at 23:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 11 2023 at 23:20):

sunfishcode updated PR #5562 from sunfishcode/zero-equality to main.

Wasmtime GitHub notifications bot (Jan 12 2023 at 00:24):

sunfishcode merged PR #5562.

Last updated: Nov 22 2024 at 16:03 UTC