Stream: git-wasmtime

Topic: wasmtime / PR #5538 cranelift-isle: Record all binding names

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 01:56):

jameysharp requested elliottt for a review on PR #5538.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 01:56):

jameysharp opened PR #5538 from isle-names to main:

...not just the ones at the outer scope of a rule.

Thanks to @avanhatt for pointing out that #5221 didn't capture as much information as I intended it to.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 16:38):

avanhatt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 16:38):

avanhatt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 16:38):

avanhatt created PR review comment:

Nit: maybe a comment for whether the indices on this vec are meaningful?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 18:05):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 21:18):

jameysharp updated PR #5538 from isle-names to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 21:18):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 21:18):

jameysharp created PR review comment:

Sure, more documentation is rarely a bad idea. :grin: Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 21:19):

jameysharp has enabled auto merge for PR #5538.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 06 2023 at 22:00):

jameysharp merged PR #5538.

Last updated: Oct 23 2024 at 20:03 UTC