jameysharp requested elliottt for a review on PR #5538.
jameysharp opened PR #5538 from isle-names
to main
:
...not just the ones at the outer scope of a rule.
Thanks to @avanhatt for pointing out that #5221 didn't capture as much information as I intended it to.
avanhatt submitted PR review.
avanhatt submitted PR review.
avanhatt created PR review comment:
Nit: maybe a comment for whether the indices on this vec are meaningful?
elliottt submitted PR review.
jameysharp updated PR #5538 from isle-names
to main
.
jameysharp submitted PR review.
jameysharp created PR review comment:
Sure, more documentation is rarely a bad idea. :grin: Thanks!
jameysharp has enabled auto merge for PR #5538.
jameysharp merged PR #5538.
Last updated: Dec 23 2024 at 12:05 UTC