Wasmtime GitHub notifications bot (Jan 05 2023 at 21:56): Wasmtime GitHub notifications bot (Jan 05 2023 at 21:56):lann opened PR #5535 from val-float-nan-equality to main:
In #5510 we changed the value types of these variants from u{32,64} to f{32,64}. One side effect of this change was that two NaN values would no longer compare equal. While this is behavior complies with IEEE-754 floating point operations, it broke equality assumptions in fuzzing.
This commit changes equality for Val to make NaNs compare equal. Since the component model requires NaN canonicalization, all NaN bit representations compare equal, which is different from the original behavior.
This also gives Vals the semantics of Eq again, so that trait impl has been reintroduced to related types as well.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 05 2023 at 22:00):lann updated PR #5535 from val-float-nan-equality to main.
Wasmtime GitHub notifications bot (Jan 05 2023 at 22:01):lann edited PR #5535 from val-float-nan-equality to main:
In #5510 we changed the value types of these variants from u{32,64} to f{32,64}. One side effect of this change was that two NaN values would no longer compare equal. While this is behavior complies with IEEE-754 floating point operations, it broke equality assumptions in fuzzing.
This commit changes equality for Val to make NaNs compare equal. Since the component model requires NaN canonicalization, all NaN bit representations compare equal, which is different from the original behavior.
This also gives Vals the semantics of Eq again, so that trait impl has been reintroduced to related types as well.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 06 2023 at 14:11):lann updated PR #5535 from val-float-nan-equality to main.
Wasmtime GitHub notifications bot (Jan 06 2023 at 16:40):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 06 2023 at 16:40):alexcrichton merged PR #5535.
Last updated: Dec 23 2024 at 12:05 UTC