Stream: git-wasmtime

Topic: wasmtime / PR #5530 cranelift: Cleanup SIMD `icmp` tests

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2023 at 13:16):

afonso360 opened PR #5530 from simd-icmp-tests to main:

:wave: Hey,

I was doing some triaging of old issues I've filed. In particular #3335 and #3334 which were actually issues with our trampolines not supporting SIMD booleans.

We've since removed booleans entierly, and we actually have all of those tests in our test suite already, but disabled.

This PR enables the simd-icmp tests for the backends that support them. Additionally it moves some icmp tests that were in a generic simd-comparision file into the existing files, and leaves the remaining files in the simd-fcmp.clif file.

SIMD Unsigned icmp does not seem to be implemented on x86_64 for i64x2, I've opened #5529 to track this.

Closes #3334
Closes #3335

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2023 at 13:27):

afonso360 updated PR #5530 from simd-icmp-tests to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2023 at 16:14):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2023 at 17:18):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2023 at 17:19):

elliottt merged PR #5530.

Last updated: Dec 23 2024 at 12:05 UTC