Stream: git-wasmtime

Topic: wasmtime / PR #5519 riscv64: Remove lower_br_fcmp

Wasmtime GitHub notifications bot (Jan 04 2023 at 21:37):

elliottt opened PR #5519 from trevor/riscv64-remove-lower-br-fcmp to main:

Remove the lower_br_fcmp function from the riscv64 backend. This PR only affects the emit implementation for FloatRound, replacing the uses of lower_br_fcmp with direct uses of FpuRRR and CondBr.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 04 2023 at 21:39):

elliottt edited PR #5519 from trevor/riscv64-remove-lower-br-fcmp to main:

Remove the lower_br_fcmp function from the riscv64 backend. This PR only affects the emit implementation for FloatRound, replacing the uses of lower_br_fcmp with direct uses of FpuRRR and CondBr.

Any changes in behavior here should be already covered by the runtests for ceil, floor, trunc, and nearest.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 04 2023 at 21:39):

elliottt requested jameysharp for a review on PR #5519.

Wasmtime GitHub notifications bot (Jan 04 2023 at 21:56):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 22:22):

elliottt merged PR #5519.

Last updated: Dec 23 2024 at 12:05 UTC