Stream: git-wasmtime

Topic: wasmtime / PR #5516 Small update for filename in `isle_in...

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:18):

avanhatt opened PR #5516 from patch-4 to main:

The name "clif.isle" is stale (since #4953), now two files "clif_lower.isle" and "clif_opt.isle" are generated. Not sure if that PR necessitates other changes this this doc. CC @cfallin.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:28):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:28):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:28):

jameysharp created PR review comment:

How about this phrasing?

* `target/.../out/clif_lower.isle`: Auto-generated declarations and helpers
  for working with CLIF for instruction lowering inside ISLE. Generated by
  `cranelift/codegen/build.rs`, which builds it into every backend.

* `target/.../out/clif_opt.isle`: Auto-generated declarations and helpers for
  working with CLIF for mid-end optimizations. Generated by
  `cranelift/codegen/build.rs`, which builds it into the mid-end optimizer.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:32):

avanhatt submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:32):

avanhatt created PR review comment:

Definitely better, thanks!

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:32):

avanhatt updated PR #5516 from patch-4 to main.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:42):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:43):

jameysharp has enabled auto merge for PR #5516.

Wasmtime GitHub notifications bot (Jan 04 2023 at 20:06):

jameysharp merged PR #5516.

Last updated: Dec 23 2024 at 12:05 UTC