Stream: git-wasmtime

Topic: wasmtime / PR #5515 riscv64: Remove the TrapFf constructor

Wasmtime GitHub notifications bot (Jan 04 2023 at 18:03):

elliottt opened PR #5515 from trevor/riscv64-remove-trapff to main:

Remove the MInst::TrapFf instruction in the riscv64 backend. It was only used in two places in the emit case for FloatRound, and was easily replaced with a combination of FpuRRR and TrapIf.

This gets us a little bit closer to removing lower_br_fcmp completely.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 04 2023 at 18:43):

elliottt has marked PR #5515 as ready for review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 18:43):

elliottt requested jameysharp for a review on PR #5515.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:12):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 04 2023 at 19:54):

elliottt updated PR #5515 from trevor/riscv64-remove-trapff to main.

Wasmtime GitHub notifications bot (Jan 04 2023 at 21:34):

elliottt merged PR #5515.

Last updated: Dec 06 2025 at 06:05 UTC