Stream: git-wasmtime

Topic: wasmtime / PR #5511 cranelift-wasm: Better track reachabi...

Wasmtime GitHub notifications bot (Jan 03 2023 at 21:35):

fitzgen opened PR #5511 from issues-5455-and-5456 to main:

We can sometimes statically determine that a given load will unconditionally trap. When this happens, we emit an unconditional trap, and we need to stop adding new instructions to the block. This commit introduces a Reachability<T> type that is like Option<T> but specifically for communicating reachability and is marked must_use to receivers to handle transitions from reachable to unreachable states.

Additionally, adds handling of reachable -> unreachable state transitions to some SIMD op translations that weren't checking for it.

Fixes #5455
Fixes #5456

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 03 2023 at 21:35):

fitzgen requested alexcrichton for a review on PR #5511.

Wasmtime GitHub notifications bot (Jan 03 2023 at 21:36):

fitzgen edited PR #5511 from issues-5455-and-5456 to main:

We can sometimes statically determine that a given load will unconditionally trap. When this happens, we emit an unconditional trap, and we need to stop adding new instructions to the block. This commit introduces a Reachability<T> type that is like Option<T> but specifically for communicating reachability and is marked must_use to force receivers to handle transitions from reachable to unreachable states.

Additionally, adds handling of reachable -> unreachable state transitions to some SIMD op translations that weren't checking for it.

Fixes #5455
Fixes #5456

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 03 2023 at 21:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 03 2023 at 21:39):

fitzgen has enabled auto merge for PR #5511.

Wasmtime GitHub notifications bot (Jan 03 2023 at 22:04):

fitzgen merged PR #5511.

Last updated: Nov 22 2024 at 16:03 UTC