Stream: git-wasmtime

Topic: wasmtime / PR #5509 Add `wasmtime::UnknownImportError`

Wasmtime GitHub notifications bot (Jan 03 2023 at 18:16):

lann opened PR #5509 from unknown-import-error to main:

This adds a new error type UnknownImportError which will be returned (wrapped in an anyhow::Error) by Linker::instantiate{,_async,_pre} if a module has an unresolvable import.

This error type is also used by Linker::define_unknown_imports_as_traps; any resulting traps will also downcast to UnknownImportError.

Closes #5416

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 03 2023 at 18:24):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 03 2023 at 18:24):

alexcrichton has enabled auto merge for PR #5509.

Wasmtime GitHub notifications bot (Jan 03 2023 at 19:01):

alexcrichton merged PR #5509.

Last updated: Oct 23 2024 at 20:03 UTC