Stream: git-wasmtime

Topic: wasmtime / PR #5507 wasmtime: Add Android AArch64 check C...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 01 2023 at 18:35):

afonso360 opened PR #5507 from android-ci to main:

:wave: Hey,

We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build.

See #5323 and #5331 for context.

cc: @bnjbvr

view this post on Zulip Wasmtime GitHub notifications bot (Jan 02 2023 at 14:32):

afonso360 updated PR #5507 from android-ci to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 02 2023 at 14:37):

afonso360 updated PR #5507 from android-ci to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 02 2023 at 14:50):

bnjbvr submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 16:49):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 16:49):

alexcrichton created PR review comment:

Could this use a cached install like mdbook and I think cargo-deny to speed this up a little as well?

Additionally, like the FreeBSD support, could this get lumped into the generic "Check" job since it's quite quick?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 17:48):

afonso360 updated PR #5507 from android-ci to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:04):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:32):

afonso360 updated PR #5507 from android-ci to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2023 at 14:46):

alexcrichton merged PR #5507.

Last updated: Nov 22 2024 at 17:03 UTC