afonso360 opened PR #5505 from fix-iabs
to main
:
When lowering
iabs
, we were accidentally comparing the unextended value, this caused the instruction to misbehave with certain top bits.This commit also adds a zbb lowering that does not use jumps.
Fixes #5501
elliottt submitted PR review.
elliottt submitted PR review.
elliottt created PR review comment:
As
fits_in_64
will also cover floating point types, what do you think about reworking the two type assertions to(fits_in_64 (ty_int ty))
?
elliottt created PR review comment:
Similarly here: we're only handling integer types for what looks like a general-purpose function, let's tighten up the type restriction to use
ty_int
as well.
afonso360 updated PR #5505 from fix-iabs
to main
.
elliottt merged PR #5505.
Last updated: Dec 23 2024 at 12:05 UTC