Stream: git-wasmtime

Topic: wasmtime / PR #5505 riscv64: Fix masking on `iabs`

view this post on Zulip Wasmtime GitHub notifications bot (Jan 01 2023 at 17:05):

afonso360 opened PR #5505 from fix-iabs to main:

When lowering iabs, we were accidentally comparing the unextended value, this caused the instruction to misbehave with certain top bits.

This commit also adds a zbb lowering that does not use jumps.

Fixes #5501

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:48):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:48):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:48):

elliottt created PR review comment:

As fits_in_64 will also cover floating point types, what do you think about reworking the two type assertions to (fits_in_64 (ty_int ty))?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:48):

elliottt created PR review comment:

Similarly here: we're only handling integer types for what looks like a general-purpose function, let's tighten up the type restriction to use ty_int as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 21:26):

afonso360 updated PR #5505 from fix-iabs to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2023 at 01:37):

elliottt merged PR #5505.

Last updated: Oct 23 2024 at 20:03 UTC