Stream: git-wasmtime

Topic: wasmtime / PR #5504 riscv64: Add masking for small types ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 31 2022 at 17:57):

afonso360 opened PR #5504 from fix-5498 to main:

:wave: Hey,

When lowering select+icmp we have an optimization that allows us to avoid materializing the icmp result.

We were accidentally not masking out the high bits for i8 and i16 in this case.

Issue #5498 reported this as an illegal instruction but what was happening there, was that the invalid select caused a division by zero.

Fixes #5498

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:51):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 18:51):

elliottt has enabled auto merge for PR #5504.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2023 at 19:59):

elliottt merged PR #5504.

Last updated: Nov 22 2024 at 16:03 UTC