Stream: git-wasmtime

Topic: wasmtime / PR #5502 fuzzgen: Disable unimplemented riscv6...

Wasmtime GitHub notifications bot (Jan 12 2023 at 15:52):

afonso360 edited PR #5502 from fuzz-riscv64 to main:

:wave: Hey,

This is a WIP PR to disable all the missing and broken instructions in fuzzgen for the riscv64 backend.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:14):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:46):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:46):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:46):

jameysharp created PR review comment:

As an observation for any of us working on this list in the future, exceptions like these can be abbreviated by using more wildcards:

                // https://github.com/bytecodealliance/wasmtime/issues/5523
                (Opcode::Rotl, &[I128, _]),
                // https://github.com/bytecodealliance/wasmtime/issues/5525
                (Opcode::Sextend, _, &[I128]),

I don't think that's important, I just wanted to mention it while merging this.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:46):

jameysharp merged PR #5502.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:50):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jan 12 2023 at 16:50):

afonso360 created PR review comment:

Oh, I didn't know that! That's really nice!

Last updated: Nov 22 2024 at 16:03 UTC