Stream: git-wasmtime

Topic: wasmtime / PR #5495 Cranelift: aarch64: lower umin.i64 an...

Wasmtime GitHub notifications bot (Dec 28 2022 at 21:39):

Mrmaxmeier opened PR #5495 from aarch64-lower-umin-i64 to main:

Hi,

I'm using umin/umax with i32 and noticed the aarch64 backend doesn't support these operations yet.
The existing rules for vector types seem to apply to scalars as well, so I'm applying a higher priority to the new rules.

The code I'm generating mostly matches Clang/GCC but they emit and 0xffff instead of uxth for unsigned sign extension of i16 and i8 :shrug:

Note that this PR doesn't support i128 though, so it's only a partial fix for #4313 (xref #3370)
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [x] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 28 2022 at 22:08):

Mrmaxmeier edited PR #5495 from aarch64-lower-umin-i64 to main:

Hi,

I'm using umin/umax with i32 and noticed the aarch64 backend doesn't support these operations yet.
The existing rules for vector types seem to apply to scalars as well, so I'm using a higher priority for the new rules.

The code I'm generating mostly matches Clang/GCC but they emit and 0xffff instead of uxth for unsigned sign extension of i16 and i8 :shrug:

Note that this PR doesn't support i128 though, so it's only a partial fix for #4313 (xref #3370)
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [x] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 28 2022 at 22:52):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Dec 28 2022 at 23:52):

Mrmaxmeier updated PR #5495 from aarch64-lower-umin-i64 to main.

Wasmtime GitHub notifications bot (Dec 30 2022 at 02:03):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Dec 30 2022 at 02:03):

jameysharp merged PR #5495.

Last updated: Dec 23 2024 at 12:05 UTC