Stream: git-wasmtime

Topic: wasmtime / PR #5473 cranelift: Support derived instructio...

Wasmtime GitHub notifications bot (Dec 19 2022 at 22:38):

elliottt opened PR #5473 from trevor/raw-instruction-defs to main:

Add the InsnBuilderDerived trait as a place to add new derived builder functions. Also add support in the instruction specificaton dsl for marking instructions as raw, which indicates that their generated builder function is not meant to be the primary interface for generating that instruction.

As an example, port over the jump builder function with an implementation that dispatches directly to the raw jump_ builder function. This functionality will greatly simplify landing #5464, where the largest portion of the diff is due to the arguments of the jump builder function changing.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 19 2022 at 23:00):

elliottt requested cfallin for a review on PR #5473.

Wasmtime GitHub notifications bot (Dec 19 2022 at 23:00):

elliottt requested jameysharp for a review on PR #5473.

Wasmtime GitHub notifications bot (Dec 20 2022 at 00:10):

elliottt closed without merge PR #5473.

Last updated: Oct 23 2024 at 20:03 UTC