Stream: git-wasmtime

Topic: wasmtime / PR #5462 Implement vsplit in cranelift interpr...

Wasmtime GitHub notifications bot (Dec 16 2022 at 22:39):

MozarellaMan opened PR #5462 from implement_vsplit_in_cranelift_interpreter to main:

<!--
Please ensure that the following steps are all taken care of before submitting
the PR.

• [x] This has been discussed in issue #..., or if not, please tell us why
  here.

• x ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->
This change is for #5454

Adds implementation for vsplit opcode to the cranelift IR interpreter. This felt surprisingly straightfoward to add! (I think)
The ir.md document was very helpful and interesting to read through.

Steps to test

cargo run -- test filetests\filetests\runtests\simd-vsplit.clif

Wasmtime GitHub notifications bot (Dec 16 2022 at 23:14):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Dec 16 2022 at 23:14):

jameysharp has enabled auto merge for PR #5462.

Wasmtime GitHub notifications bot (Dec 16 2022 at 23:14):

jameysharp merged PR #5462.

Last updated: Dec 23 2024 at 12:05 UTC