Stream: git-wasmtime

Topic: wasmtime / PR #5461 cranelift-codegen: Add support for im...

Wasmtime GitHub notifications bot (Dec 16 2022 at 21:28):

saulecabrera opened PR #5461 from x64-imm-mem-mov to main:

This change adds support for immediate to memory moves in x64 which are needed by Winch for zeroing local slots.

This change follows the guideline in isa/x64/inst/emit and uses other instructions (immediate to register moves) as a base for the test cases.

The instruction encoding expectation was derived by assembling each instruction and inspecting the assembly with objdump.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 16 2022 at 21:28):

saulecabrera requested cfallin for a review on PR #5461.

Wasmtime GitHub notifications bot (Dec 17 2022 at 00:35):

cfallin created PR review comment:

Can we add Size16 and Size8 cases here too?

Wasmtime GitHub notifications bot (Dec 17 2022 at 00:35):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 17 2022 at 00:35):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 17 2022 at 00:35):

cfallin created PR review comment:

Add a comment here perhaps that we don't need always_emit_if_8bit_needed() on the REX flags, because the dst is a memory operand, not a possibly 8-bit register?

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera updated PR #5461 from x64-imm-mem-mov to main.

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera created PR review comment:

Done, thanks!

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera created PR review comment:

Agreed, done!

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Dec 18 2022 at 22:05):

saulecabrera requested cfallin for a review on PR #5461.

Wasmtime GitHub notifications bot (Dec 19 2022 at 17:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2022 at 17:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2022 at 17:47):

cfallin created PR review comment:

Can we update this comment to include the prefix as well?

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:18):

saulecabrera updated PR #5461 from x64-imm-mem-mov to main.

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:19):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:19):

saulecabrera created PR review comment:

Good catch, thanks! Updated!

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:21):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:21):

cfallin has enabled auto merge for PR #5461.

Wasmtime GitHub notifications bot (Dec 19 2022 at 21:54):

cfallin merged PR #5461.

Last updated: Dec 23 2024 at 13:07 UTC