Stream: git-wasmtime

Topic: wasmtime / PR #5460 x64: support select_spectre_guard on ...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):

cfallin opened PR #5460 from x64-select-spectre-guard-i128 to main:

Fixes #5452.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):

cfallin requested elliottt for a review on PR #5460.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):

cfallin requested jameysharp for a review on PR #5460.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:50):

jameysharp created PR review comment:

This file is configured to run on aarch64 as well as x64, so I'm expecting CI to fail when it tries to run this test on aarch64. I assume we can't add this test here without fixing at least #5453 as well.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:50):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:56):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 19:56):

cfallin created PR review comment:

Hmm, yeah, I'll take a look at that...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 20:26):

cfallin updated PR #5460 from x64-select-spectre-guard-i128 to main.


Last updated: Dec 23 2024 at 12:05 UTC