Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41): Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):cfallin opened PR #5460 from x64-select-spectre-guard-i128 to main:
Fixes #5452.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):cfallin requested elliottt for a review on PR #5460.
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:41):cfallin requested jameysharp for a review on PR #5460.
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:50):jameysharp created PR review comment:
This file is configured to run on aarch64 as well as x64, so I'm expecting CI to fail when it tries to run this test on aarch64. I assume we can't add this test here without fixing at least #5453 as well.
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:50):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:56):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2022 at 19:56):cfallin created PR review comment:
Hmm, yeah, I'll take a look at that...
Wasmtime GitHub notifications bot (Dec 16 2022 at 20:26):cfallin updated PR #5460 from x64-select-spectre-guard-i128 to main.
Last updated: Nov 22 2024 at 17:03 UTC