Wasmtime GitHub notifications bot (Dec 16 2022 at 16:44): Wasmtime GitHub notifications bot (Dec 16 2022 at 16:44):alexcrichton opened PR #5459 from asm-sym to main:
Avoids extra
#[no_inline]functions and undue symbols being exposed from Wasmtime. This is a newly stabilized feature in Rust 1.66.0. I've also added arust-versionentry to thewasmtimecrate to try to head off possible reports in the future about odd error messages or usage of unstable features if the rustc version is too old.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 16 2022 at 16:46):alexcrichton updated PR #5459 from asm-sym to main.
Wasmtime GitHub notifications bot (Dec 16 2022 at 16:46):alexcrichton edited PR #5459 from asm-sym to main:
Avoids extra
#[no_mangle]functions and undue symbols being exposed from Wasmtime. This is a newly stabilized feature in Rust 1.66.0. I've also added arust-versionentry to thewasmtimecrate to try to head off possible reports in the future about odd error messages or usage of unstable features if the rustc version is too old.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 16 2022 at 17:13):alexcrichton updated PR #5459 from asm-sym to main.
Wasmtime GitHub notifications bot (Dec 16 2022 at 18:22):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2022 at 18:47):alexcrichton updated PR #5459 from asm-sym to main.
Wasmtime GitHub notifications bot (Dec 16 2022 at 18:47):alexcrichton has enabled auto merge for PR #5459.
Wasmtime GitHub notifications bot (Dec 16 2022 at 20:12):alexcrichton merged PR #5459.
Last updated: Dec 23 2024 at 12:05 UTC