Stream: git-wasmtime

Topic: wasmtime / PR #5439 Cranelift: Add `.wat` to assembly tes...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:05):

fitzgen opened PR #5439 from wasm-compile-tests to main:

This is just the .wat-to-assembly support from https://github.com/bytecodealliance/wasmtime/pull/5386 as well as the generated tests. By landing this first, and rebasing that on top of this, we can check for regressions and perturbations caused by moving where heap legalization is done in that PR.

@cfallin or @jameysharp want to take a look? Nothing has changed from that original PR other than minor rebase related things.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:05):

fitzgen requested jameysharp for a review on PR #5439.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:05):

fitzgen requested cfallin for a review on PR #5439.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:17):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:27):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:27):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:27):

jameysharp created PR review comment:

This comment has the wrong filename pattern in it now.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:27):

jameysharp created PR review comment:

I was hoping we could run legalization in the non-compile case so the wat->clif tests would show any differences in generated CLIF when you rebase the other PR on this.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:38):

fitzgen created PR review comment:

I think the wasm-to-assembly tests should catch that in practice, and I don't really want to add and enable an option that we will immediately stop using after the other PR lands.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:38):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:38):

fitzgen updated PR #5439 from wasm-compile-tests to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:38):

fitzgen created PR review comment:

Good catch!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:38):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:39):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:39):

jameysharp created PR review comment:

Sure, that's fair.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 20:39):

fitzgen has enabled auto merge for PR #5439.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 21:13):

fitzgen merged PR #5439.


Last updated: Dec 23 2024 at 13:07 UTC