Wasmtime GitHub notifications bot (Dec 13 2022 at 23:11): Wasmtime GitHub notifications bot (Dec 13 2022 at 23:11):elliottt opened PR #5430 from trevor/fixed-nonallocatable-aliases to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:15):elliottt edited PR #5430 from trevor/fixed-nonallocatable-aliases to main:
The only situation where we use physical registers now is for fixed non-allocatable registers, all other uses should be virtual register. As such, it no longer makes sense to track aliases of registers that aren't virtual, as that would imply that it's acceptable to satisfy a constraint by using a non-allocatable register.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:25):elliottt updated PR #5430 from trevor/fixed-nonallocatable-aliases to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:29):elliottt updated PR #5430 from trevor/fixed-nonallocatable-aliases to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:37):elliottt updated PR #5430 from trevor/fixed-nonallocatable-aliases to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:38):elliottt updated PR #5430 from trevor/fixed-nonallocatable-aliases to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:39):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:39):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:39):cfallin created PR review comment:
s/alias/move/ -- "aliases" are what are used to make one vreg resolve to another (so that result vregs can be rewritten to the temp vregs returned by the toplevel lowering entry point), and imply a "timeless" equivalence, while "moves" are specific copy operations that occur in program flow. (Likewise the title of this PR/commit should change)
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:42):elliottt updated PR #5430 from trevor/fixed-nonallocatable-aliases to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:43):elliottt has marked PR #5430 as ready for review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 23:43):elliottt edited PR #5430 from trevor/fixed-nonallocatable-aliases to main:
The only situation where we use physical registers now is for fixed non-allocatable registers, all other uses should be virtual register. As such, it no longer makes sense to track aliases of registers that aren't virtual, as that would imply that it's acceptable to satisfy a constraint by using a non-allocatable register.
Fixes #5425
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Last updated: Oct 23 2024 at 20:03 UTC