Stream: git-wasmtime

Topic: wasmtime / PR #5429 Simplify "unimplemented" operation er...

Wasmtime GitHub notifications bot (Dec 13 2022 at 21:23):

uweigand opened PR #5429 from unimplemented to main:

Now that all operations are implemented in ISLE, simplify Rust code by providing a generic error message if any operation is not implemented in ISLE. Done across all targets.

@cfallin - as requested here https://github.com/bytecodealliance/wasmtime/pull/5427#pullrequestreview-1216397097

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 13 2022 at 21:33):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 21:34):

cfallin has enabled auto merge for PR #5429.

Wasmtime GitHub notifications bot (Dec 13 2022 at 21:35):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 22:26):

cfallin has disabled auto merge for PR #5429.

Wasmtime GitHub notifications bot (Dec 13 2022 at 23:22):

jameysharp merged PR #5429.

Last updated: Nov 22 2024 at 16:03 UTC