Wasmtime GitHub notifications bot (Dec 13 2022 at 18:39): Wasmtime GitHub notifications bot (Dec 13 2022 at 18:39):cfallin opened PR #5426 from risc-v-etor-fix to main:
This extractor had a side-effect of invoking
put_in_regs, which is not supposed to be invoked until the pattern-matching commits to evaluating a rule right-hand side (i.e., cannot backtrack). In this case the side-effect was mostly benign (in theory it could have caused additional values to be computed needlessly), but in general we should be careful to keep side-effects out of the left-hand side to enable further optimizations and work on islec.The implicit conversion from
ValuetoRegturns out to be enough to make the rules in question work, so we can simply remove the use of the extractor in this case.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 13 2022 at 18:39):cfallin requested jameysharp for a review on PR #5426.
Wasmtime GitHub notifications bot (Dec 13 2022 at 18:40):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 19:01):cfallin updated PR #5426 from risc-v-etor-fix to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 19:03):cfallin updated PR #5426 from risc-v-etor-fix to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 19:05):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 19:12):cfallin updated PR #5426 from risc-v-etor-fix to main.
Wasmtime GitHub notifications bot (Dec 13 2022 at 19:47):cfallin merged PR #5426.
Last updated: Dec 23 2024 at 12:05 UTC