Wasmtime GitHub notifications bot (Dec 13 2022 at 01:09): Wasmtime GitHub notifications bot (Dec 13 2022 at 01:09):elliottt opened PR #5424 from trevor/share-zero to main:
Share a zero value in the translation of ushr for i128. This increases the lifetime of the value by a few instructions, and reduces the number of registers used in the translation by one, which seems like an acceptable trade-off.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 13 2022 at 01:10):elliottt requested jameysharp for a review on PR #5424.
Wasmtime GitHub notifications bot (Dec 13 2022 at 01:10):elliottt requested cfallin for a review on PR #5424.
Wasmtime GitHub notifications bot (Dec 13 2022 at 01:15):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 13 2022 at 02:15):elliottt merged PR #5424.
Last updated: Dec 23 2024 at 12:05 UTC