Stream: git-wasmtime

Topic: wasmtime / PR #5423 aarch64: Use unsigned constants where...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:19):

jameysharp requested elliottt for a review on PR #5423.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:19):

jameysharp opened PR #5423 from aarch64-signed-consts to main:

The Rust type expected in these locations is unsigned, but these constants are negative. ISLE currently emits a Rust expression with extra type conversions in order to make this work as intended.

However, across all backends, only these three aarch64 constants use this particular "feature" of ISLE, and I want to make it go away.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin created PR review comment:

Here, can we spell out 0xffff_ffff_ffff_ffff? It's kind of awkward, but otherwise we have an extra call to an external constructor that may or may not be inlined + constant-propagated.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin created PR review comment:

Likewise here, 0xffff_ffff_ffff_ff80, and below, 0xffff_ffff_ffff_8000.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 21:24):

jameysharp updated PR #5423 from aarch64-signed-consts to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 22:35):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 23:03):

jameysharp has enabled auto merge for PR #5423.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 23:08):

jameysharp merged PR #5423.


Last updated: Nov 22 2024 at 16:03 UTC