Stream: git-wasmtime

Topic: wasmtime / PR #5423 aarch64: Use unsigned constants where...

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:19):

jameysharp requested elliottt for a review on PR #5423.

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:19):

jameysharp opened PR #5423 from aarch64-signed-consts to main:

The Rust type expected in these locations is unsigned, but these constants are negative. ISLE currently emits a Rust expression with extra type conversions in order to make this work as intended.

However, across all backends, only these three aarch64 constants use this particular "feature" of ISLE, and I want to make it go away.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin created PR review comment:

Here, can we spell out 0xffff_ffff_ffff_ffff? It's kind of awkward, but otherwise we have an extra call to an external constructor that may or may not be inlined + constant-propagated.

Wasmtime GitHub notifications bot (Dec 13 2022 at 00:32):

cfallin created PR review comment:

Likewise here, 0xffff_ffff_ffff_ff80, and below, 0xffff_ffff_ffff_8000.

Wasmtime GitHub notifications bot (Dec 13 2022 at 21:24):

jameysharp updated PR #5423 from aarch64-signed-consts to main.

Wasmtime GitHub notifications bot (Dec 13 2022 at 22:35):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 23:03):

jameysharp has enabled auto merge for PR #5423.

Wasmtime GitHub notifications bot (Dec 13 2022 at 23:08):

jameysharp merged PR #5423.

Last updated: Dec 23 2024 at 13:07 UTC