Stream: git-wasmtime

Topic: wasmtime / PR #5420 Cranelift: implement general select_s...

Wasmtime GitHub notifications bot (Dec 12 2022 at 19:35):

cfallin opened PR #5420 from issue-5417 to main:

When adding some optimization rules for icmp in the egraph infrastructure, we ended up creating a path to legal CLIF but with patterns unsupported by three of our four backends: specifically, select_spectre_guard with a general truthy input, rather than an icmp.

In #5206 we discussed replacing select_spectre_guard with something more specific, and that could still be a long-term solution here, but doing so now would interfere with ongoing refactoring of heap access lowering, so I've opted not to do so. (In that issue I was concerned about complexity and didn't see the need but with this fuzzbug I'm starting to feel a bit differently; maybe we should remove this non-orthogonal op in the long run.)

Fixes #5417.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 12 2022 at 19:35):

cfallin requested elliottt for a review on PR #5420.

Wasmtime GitHub notifications bot (Dec 12 2022 at 19:35):

cfallin requested fitzgen for a review on PR #5420.

Wasmtime GitHub notifications bot (Dec 12 2022 at 19:35):

cfallin requested jameysharp for a review on PR #5420.

Wasmtime GitHub notifications bot (Dec 12 2022 at 20:36):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 01:13):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Dec 13 2022 at 01:13):

cfallin merged PR #5420.

Last updated: Dec 23 2024 at 13:07 UTC