Stream: git-wasmtime

Topic: wasmtime / PR #5406 Remove IFLAGS/FFLAGS types

Wasmtime GitHub notifications bot (Dec 09 2022 at 17:53):

uweigand opened PR #5406 from no-iflags to main:

All instructions using the CPU flags types (IFLAGS/FFLAGS) were already removed. This patch completes the cleanup by removing all remaining instructions that define values of CPU flags types, as well as the types themselves.

Specifically, the following features are removed:

• The IFLAGS and FFLAGS types and the SpecialType category.
• Special handling of IFLAGS and FFLAGS in machinst/isle.rs and machinst/lower.rs.
• The ifcmp, ifcmp_imm, ffcmp, iadd_ifcin, iadd_ifcout, iadd_ifcarry, isub_ifbin, isub_ifbout, and isub_ifborrow instructions.
• The writes_cpu_flags instruction property.
• The flags verifier pass.
• Flags handling in the interpreter.

All of these features are currently unused; no functional change intended by this patch.

This addresses https://github.com/bytecodealliance/wasmtime/issues/3249.

CC @cfallin @elliottt @jameysharp

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 09 2022 at 17:57):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Dec 09 2022 at 17:57):

bjorn3 created PR review comment:

Rather than removing this test, could you change it to avoid iflags?

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:01):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:01):

bjorn3 created PR review comment:

Maybe test parsing select instead? That is also a ternary instruction.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:20):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:26):

uweigand updated PR #5406 from no-iflags to main.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:26):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:26):

uweigand created PR review comment:

Ah, I see I misinterpreted the purpose of the test. Now changed to use iadd_cout / icmp instead of iadd_ifcout / ifcmp instead.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:27):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:27):

uweigand created PR review comment:

Changed to iadd_cout and friends as well. Also added a select test for completeness.

Wasmtime GitHub notifications bot (Dec 09 2022 at 18:30):

uweigand updated PR #5406 from no-iflags to main.

Wasmtime GitHub notifications bot (Dec 09 2022 at 20:12):

uweigand updated PR #5406 from no-iflags to main.

Wasmtime GitHub notifications bot (Dec 09 2022 at 21:42):

cfallin merged PR #5406.

Last updated: Dec 23 2024 at 13:07 UTC