Stream: git-wasmtime

Topic: wasmtime / PR #5369 aarch64: Rework amode compilation to ...

Wasmtime GitHub notifications bot (Dec 01 2022 at 23:15):

elliottt opened PR #5369 from trevor/ssa-aarch64-amode to main:

Rework the compilation of amodes in the aarch64 backend to stop reusing registers and instead generate fresh virtual registers for intermediates. This resolves some SSA checker violations with the aarch64 backend, and gets us closer to having cranelift produce SSA code in general.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2022 at 23:19):

elliottt edited PR #5369 from trevor/ssa-aarch64-amode to main:

Rework the compilation of amodes in the aarch64 backend to stop reusing registers and instead generate fresh virtual registers for intermediates. This resolves some SSA checker violations with the aarch64 backend, and as a nice side-effect removes some unnecessary movs in the generated code.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2022 at 23:23):

elliottt requested cfallin for a review on PR #5369.

Wasmtime GitHub notifications bot (Dec 01 2022 at 23:24):

elliottt requested fitzgen for a review on PR #5369.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:16):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:16):

cfallin created PR review comment:

The move is slightly awkward here; is there a way we could rewrite the AMode we created above to use init directly? (I know this is kind of awkward because we need to do the above match first to get the reg addend, but perhaps we could have a .replace_first_reg(..) on the AMode or something like that.)

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:16):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:42):

elliottt updated PR #5369 from trevor/ssa-aarch64-amode to main.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:44):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:52):

elliottt updated PR #5369 from trevor/ssa-aarch64-amode to main.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:54):

elliottt updated PR #5369 from trevor/ssa-aarch64-amode to main.

Wasmtime GitHub notifications bot (Dec 02 2022 at 00:56):

elliottt has enabled auto merge for PR #5369.

Wasmtime GitHub notifications bot (Dec 02 2022 at 01:23):

elliottt merged PR #5369.

Last updated: Dec 23 2024 at 12:05 UTC