Stream: git-wasmtime

Topic: wasmtime / PR #5366 Allocate temporary intermediates when...

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:14):

elliottt opened PR #5366 from trevor/ssa-aarch64-load-constant to main:

As loading constants on aarch64 can take up to 4 instructions, we need to plumb through some additional registers. Rather than pass a fixed list of registers in, pass an allocation function.

This forced a change to ABIMachineSpec::gen_memcpy, as it now needed to take an allocator to pass to uses of gen_constant. As a result, I removed the fixed temporary arguments and passed an allocator instead.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:19):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:19):

elliottt created PR review comment:

The two consecutive calls to load_constant are what's forcing the alloc_tmp argument to load_constant to be a mutable reference.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:21):

elliottt updated PR #5366 from trevor/ssa-aarch64-load-constant to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:22):

elliottt requested jameysharp for a review on PR #5366.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:22):

elliottt requested fitzgen for a review on PR #5366.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:53):

elliottt created PR review comment:

I need to update the implementation in lower/isle.rs before merging this pr.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:53):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:05):

elliottt updated PR #5366 from trevor/ssa-aarch64-load-constant to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:16):

elliottt updated PR #5366 from trevor/ssa-aarch64-load-constant to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 21:55):

elliottt updated PR #5366 from trevor/ssa-aarch64-load-constant to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 21:56):

elliottt has enabled auto merge for PR #5366.

Wasmtime GitHub notifications bot (Dec 01 2022 at 22:29):

elliottt merged PR #5366.

Last updated: Dec 23 2024 at 13:07 UTC