Stream: git-wasmtime

Topic: wasmtime / PR #5357 Allocate a temporary for 64-bit const...

Wasmtime GitHub notifications bot (Dec 01 2022 at 00:20):

elliottt opened PR #5357 from trevor/s390x-constant-ssa to main:

Avoid reusing a destination virtual register for 64-bit constants in the s390x backend. This change addresses a case identified by the regalloc2 ssa validator, as the destination register was written to twice when constants were generated via the MachInst::gen_constant function.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2022 at 00:28):

elliottt updated PR #5357 from trevor/s390x-constant-ssa to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 00:30):

elliottt requested fitzgen for a review on PR #5357.

Wasmtime GitHub notifications bot (Dec 01 2022 at 00:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 00:42):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 01:01):

elliottt merged PR #5357.

Last updated: Nov 22 2024 at 17:03 UTC