Stream: git-wasmtime

Topic: wasmtime / PR #5356 Don't reuse registers in the x64 div ...

Wasmtime GitHub notifications bot (Nov 30 2022 at 22:06):

elliottt opened PR #5356 from trevor/make-div-ssa to main:

Introduce a temporary for an intermediate value in the lowering of div in the x64 backend. Additionally, add a src argument to the shift_r smart constructor, which is why the diff got larger than just the div lowering.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 30 2022 at 22:08):

elliottt requested cfallin for a review on PR #5356.

Wasmtime GitHub notifications bot (Nov 30 2022 at 22:25):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 30 2022 at 22:36):

elliottt has enabled auto merge for PR #5356.

Wasmtime GitHub notifications bot (Nov 30 2022 at 22:45):

elliottt merged PR #5356.

Last updated: Oct 23 2024 at 20:03 UTC