Wasmtime GitHub notifications bot (Nov 30 2022 at 16:57): Wasmtime GitHub notifications bot (Nov 30 2022 at 16:57):elliottt opened PR #5354 from trevor/fuzz-with-ssa-checker to main:
Enable regalloc2's SSA verifier in debug builds to check for any outstanding reuse of virtual registers in def constraints. As fuzzing enables
debug_assertions, this will enable the SSA verifier when fuzzing as well.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 30 2022 at 16:58):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 06 2022 at 23:39):elliottt updated PR #5354 from trevor/fuzz-with-ssa-checker to main.
Wasmtime GitHub notifications bot (Dec 07 2022 at 00:47):elliottt has marked PR #5354 as ready for review.
Wasmtime GitHub notifications bot (Dec 07 2022 at 00:47):elliottt requested cfallin for a review on PR #5354.
Wasmtime GitHub notifications bot (Dec 07 2022 at 16:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 07 2022 at 16:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 07 2022 at 16:55):cfallin created PR review comment:
This seems fine IMHO; from the point-of-view of regalloc semantics, a trap might as well be a return (control leaves the function and there are no successors).
Wasmtime GitHub notifications bot (Dec 07 2022 at 17:12):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Dec 07 2022 at 17:12):elliottt created PR review comment:
Thanks, I'll remove this TODO :+1:
Wasmtime GitHub notifications bot (Dec 07 2022 at 17:39):elliottt updated PR #5354 from trevor/fuzz-with-ssa-checker to main.
Wasmtime GitHub notifications bot (Dec 07 2022 at 20:22):elliottt merged PR #5354.
Last updated: Nov 22 2024 at 16:03 UTC