Stream: git-wasmtime

Topic: wasmtime / PR #5353 Implement inline stack probes for AAr...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 16:17):

alexcrichton opened PR #5353 from inline-probe-aarch64 to main:

This PR implements necessary support for inline stack probes in the AArch64 backend and then enables the support in Wasmtime. This builds on https://github.com/bytecodealliance/wasmtime/pull/5350 to ensure that on these hosts an accidentally misconfigured Config will still guarantee that wasm itself will run into the guard page for the stack rather than skipping over it.

The commits here have been split out with various refactorings for inline stack probes, including a minor optimization for amodes in the aarch64 backend. I'd appreciate some close review on the aarch64 bits since I'm mostly just going with what works first and I don't necessarily fully understand the implications of the changes.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 16:28):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 16:28):

bjorn3 created PR review comment:

*instruction

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 16:41):

alexcrichton updated PR #5353 from inline-probe-aarch64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin created PR review comment:

Can we keep the closing parens all together (Lisp-style)?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin created PR review comment:

s/a/an/

Also can we note here that it's careful not to use spilltmp or tmp2, so these registers are allowed to be inputs?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin created PR review comment:

Note here that this code is being generated post-regalloc, so the temps are allowable to use?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin created PR review comment:

Can we add a note here that we must be careful not to use addressing modes that use spilltmp or tmp2, and this is currently satisfied by using the reg-reg addressing mode (i.e., no large offsets, which we sometimes synthesize into a tmp)?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:28):

cfallin created PR review comment:

s/lik/like/

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:39):

alexcrichton updated PR #5353 from inline-probe-aarch64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:48):

alexcrichton updated PR #5353 from inline-probe-aarch64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:49):

alexcrichton updated PR #5353 from inline-probe-aarch64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 18:06):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 18:30):

alexcrichton merged PR #5353.

Last updated: Nov 22 2024 at 17:03 UTC