Stream: git-wasmtime

Topic: wasmtime / PR #5352 x64: reduce work in non-stack using l...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 01:03):

abrown opened PR #5352 from x64-leaf-functions to main:

Cranelift has had the ability for some time to identify leaf functions;
by Cranelift's definition, a leaf function is one that knows of no other
call signatures. https://github.com/bytecodealliance/wasmtime/issues/1148 noted how it would be a good idea to avoid extra
frame setup work in leaf functions and https://github.com/bytecodealliance/wasmtime/pull/2960 implemented this for
aarch64 and s390x. This improvement was not made for x64 due to some
test failures. This change avoids any frame setup for non-stack-using
leaf functions in x64.

Because this updates the generated code, there are multiple sets of tests
to update -- each of these is separated here into its own commit. I will follow
up in the comments with benchmark results.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 15:26):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 15:26):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 15:26):

cfallin created PR review comment:

Remove filesystem write (probably leftover temporary code)?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 16:33):

abrown updated PR #5352 from x64-leaf-functions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 17:13):

abrown updated PR #5352 from x64-leaf-functions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 23:06):

abrown updated PR #5352 from x64-leaf-functions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2022 at 18:41):

abrown updated PR #5352 from x64-leaf-functions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2022 at 19:49):

abrown updated PR #5352 from x64-leaf-functions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2022 at 11:17):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2022 at 11:17):

bjorn3 created PR review comment:

Maybe my suggestion at https://github.com/bytecodealliance/wasmtime/pull/4469#discussion_r925815651 would work? "non-leaf" could be used by default and "always" could be used on macOS.

Last updated: Nov 22 2024 at 16:03 UTC