Stream: git-wasmtime

Topic: wasmtime / PR #5351 Cranelift: implement `heap_{load,stor...

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:01):

fitzgen edited PR #5351 from heap-load-store to main:

Work in progress, do not merge.

Need to figure out what to do about the usage of heap_addr in cranelift-wasm that doesn't feed into either a load or a store but instead into something like uload8 or an atomic operation.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:01):

fitzgen requested cfallin for a review on PR #5351.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:01):

fitzgen edited PR #5351 from heap-load-store to main:

This does not remove heap_addr yet, but it does factor out the common
bounds-check-and-compute-the-native-address functionality that is shared between
all of heap_{addr,load,store}.

Finally, this adds a missing optimization for when we can dedupe explicit bounds
checks for static memories and Spectre mitigations.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:30):

cfallin created PR review comment:

s/intentinally/intentionally/

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:34):

fitzgen updated PR #5351 from heap-load-store to main.

Wasmtime GitHub notifications bot (Nov 30 2022 at 18:39):

fitzgen has enabled auto merge for PR #5351.

Wasmtime GitHub notifications bot (Nov 30 2022 at 19:12):

fitzgen merged PR #5351.

Last updated: Dec 13 2025 at 19:03 UTC