Wasmtime GitHub notifications bot (Nov 29 2022 at 20:07): Wasmtime GitHub notifications bot (Nov 29 2022 at 20:07):fitzgen opened PR #5348 from fix-heap-load-store-test-script to main:
Was missing some '$' characters and so was comparing string literals against string literals instead of variable values against string literals. Regenerated tests to fix them and add missing tests.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 29 2022 at 20:07):fitzgen requested jameysharp for a review on PR #5348.
Wasmtime GitHub notifications bot (Nov 29 2022 at 20:29):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Nov 29 2022 at 20:29):fitzgen has enabled auto merge for PR #5348.
Wasmtime GitHub notifications bot (Nov 29 2022 at 20:53):fitzgen merged PR #5348.
Last updated: Nov 22 2024 at 16:03 UTC