Stream: git-wasmtime

Topic: wasmtime / PR #5347 Remove some custom error types in Was...

Wasmtime GitHub notifications bot (Nov 29 2022 at 19:50):

alexcrichton opened PR #5347 from remove-custom-errors to main:

These types are mostly cumbersome to work with nowadays that anyhow is used everywhere else. This commit removes InstantiationError and SetupError in favor of using anyhow::Error throughout. This can eventually culminate in creation of specific errors for embedders to downcast to but for now this should be general enough.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 29 2022 at 20:27):

alexcrichton updated PR #5347 from remove-custom-errors to main.

Wasmtime GitHub notifications bot (Nov 30 2022 at 16:44):

alexcrichton updated PR #5347 from remove-custom-errors to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:38):

alexcrichton requested fitzgen for a review on PR #5347.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:44):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:47):

alexcrichton merged PR #5347.

Last updated: Nov 22 2024 at 17:03 UTC