Wasmtime GitHub notifications bot (Nov 29 2022 at 16:33): Wasmtime GitHub notifications bot (Nov 29 2022 at 16:33):jbourassa opened PR #5343 from fuel-doc-fixes to main:
Store::add_fueldocumentation said it'd panic when the engine is not configured to have fuel, but it in fact returns an error[1].There was a typo in
Store::add_fuel's documentation (either either). I "fixed" the typo by rewording the section using the same wording asStore::fuel_consumed(_if fuel consumption is not enabled via..._)<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 29 2022 at 16:33):jbourassa edited PR #5343 from fuel-doc-fixes to main:
Minor changes to the Store's documentation for fuel:
Store::add_fueldocumentation said it'd panic when the engine is not configured to have fuel, but it in fact returns an error[1].There was a typo in
Store::add_fuel's documentation (either either). I "fixed" the typo by rewording the section using the same wording asStore::fuel_consumed(_if fuel consumption is not enabled via..._)<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 29 2022 at 16:39):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 29 2022 at 16:39):alexcrichton has enabled auto merge for PR #5343.
Wasmtime GitHub notifications bot (Nov 29 2022 at 17:08):alexcrichton merged PR #5343.
Last updated: Dec 23 2024 at 12:05 UTC