Stream: git-wasmtime

Topic: wasmtime / PR #5341 Add a `WasmBacktrace::new()` constructor

Wasmtime GitHub notifications bot (Nov 29 2022 at 15:13):

alexcrichton opened PR #5341 from manual-backtrace to main:

This commit adds a method of manually capturing a backtrace of WebAssembly frames within a Store. The new constructor can be called with any AsContext values, primarily &Store and &Caller, during host functions to inspect the calling state.

For now this does not respect the Config::wasm_backtrace option and instead unconditionally captures the backtrace. It's hoped that this can continue to adapt to needs of embedders by making it more configurable int he future if necessary.

Closes #5339

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2022 at 19:38):

alexcrichton requested fitzgen for a review on PR #5341.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:44):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:44):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:44):

fitzgen created PR review comment:

Having two constructors, one forcing and one respecting the config, might be nice.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:44):

fitzgen created PR review comment:

Maybe also mention that this will only contain Wasm frames from within the given store, not other stores' frames that might be on the stack.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:55):

alexcrichton updated PR #5341 from manual-backtrace to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 20:55):

alexcrichton has enabled auto merge for PR #5341.

Wasmtime GitHub notifications bot (Dec 01 2022 at 21:45):

alexcrichton updated PR #5341 from manual-backtrace to main.

Wasmtime GitHub notifications bot (Dec 01 2022 at 22:19):

alexcrichton merged PR #5341.

Last updated: Nov 22 2024 at 17:03 UTC