Wasmtime GitHub notifications bot (Nov 28 2022 at 22:53): Wasmtime GitHub notifications bot (Nov 28 2022 at 22:53):elliottt opened PR #5334 from trevor/fix-imul-overlaps to main:
- Fix rule shadowing problems
- Add tests for imul/{s,u}widen_{low,high} combinations
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 28 2022 at 22:54):elliottt edited PR #5334 from trevor/fix-imul-overlaps to main:
Fix shadowing identified in #5322 for imul and swiden_high/swiden_low/uwiden_high/uwiden_low combinations in the x64 backend, and remove some redundant rules from the aarch64 dynamic neon ruleset. Additionally, add tests to the x64 backend showing that the imul specializations are firing.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 28 2022 at 22:54):elliottt has marked PR #5334 as ready for review.
Wasmtime GitHub notifications bot (Nov 28 2022 at 22:55):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Nov 28 2022 at 23:48):elliottt merged PR #5334.
Last updated: Nov 22 2024 at 16:03 UTC