Wasmtime GitHub notifications bot (Nov 28 2022 at 17:34): Wasmtime GitHub notifications bot (Nov 28 2022 at 17:34):bnjbvr opened PR #5331 from flush-icache-on-android-aarch64 to main:
This updates the icache flushing code so it does the flushing on Android as well. From fuzzy memories working on this in the past and quick inspection of what Firefox does these days, this is required for both Android and linux, and Android is guaranteed to have access to the
membarrierfunction.I've also slightly refactored the code to use an internal module named
details, I find it slightly cleaner as it avoids all the dead code in other combinations of targets/archs, but it's mostly esthetic, so I could revert that part.In addition to correctness, this also fixes the build of wasmtime 3.0.0 on the android architecture, which we rely on. If that fix is deemed acceptable, it would be extra nice to get a dot release of wasmtime with that build fix too!
cc @afonso360 @akirilov-arm @alexcrichton @cfallin
Last updated: Oct 23 2024 at 20:03 UTC