Stream: git-wasmtime

Topic: wasmtime / PR #5326 WIP: remove mutability from the Wasi...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 05:20):

haraldh edited PR #5326 from table_immutable to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 05:27):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table.
It also adds interior mutability to the WasiCtx Table.

Major pain points:

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 05:30):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table.
It also adds interior mutability to the WasiCtx Table.

Major pain points:

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 05:31):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table and the Table elements.

Major pain points:

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 05:32):

haraldh has marked PR #5326 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 07:50):

haraldh updated PR #5326 from table_immutable to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 07:53):

haraldh updated PR #5326 from table_immutable to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 08:21):

haraldh updated PR #5326 from table_immutable to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 09:18):

haraldh submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 09:18):

haraldh created PR review comment:

@alexcrichton it's because Windows has to reopen the file with new Flags, rather than modifying the current handle. There is just no native function for this.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2022 at 09:19):

haraldh has marked PR #5326 as ready for review.


Last updated: Dec 23 2024 at 12:05 UTC