Stream: git-wasmtime

Topic: wasmtime / PR #5326 WIP: remove mutability from the Wasi...

Wasmtime GitHub notifications bot (Nov 30 2022 at 05:20):

haraldh edited PR #5326 from table_immutable to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 30 2022 at 05:27):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table.
It also adds interior mutability to the WasiCtx Table.

Major pain points:

• File only needs RwLock<cap_std::fs::File> because of https://github.com/bytecodealliance/system-interface/blob/da238e324e752033f315f09c082ad9ce35d42696/src/fs/fd_flags.rs#L210-L217
• Because File needs a RwLock and RwLock*Guard cannot be hold across an .await, The async from async fn num_ready_bytes(&self) had to be removed
• Because File needs a RwLock and RwLock*Guard cannot be dereferenced in pollable, the signature of fn pollable(&self) -> Option<rustix::fd::BorrowedFd> changed to fn pollable(&self) -> Option<Arc<dyn AsFd + '_>>

Wasmtime GitHub notifications bot (Nov 30 2022 at 05:30):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table.
It also adds interior mutability to the WasiCtx Table.

Major pain points:

• File only needs RwLock<cap_std::fs::File> to implement File::set_fdflags() on Windows, because of https://github.com/bytecodealliance/system-interface/blob/da238e324e752033f315f09c082ad9ce35d42696/src/fs/fd_flags.rs#L210-L217
• Because File needs a RwLock and RwLock*Guard cannot be hold across an .await, The async from async fn num_ready_bytes(&self) had to be removed
• Because File needs a RwLock and RwLock*Guard cannot be dereferenced in pollable, the signature of fn pollable(&self) -> Option<rustix::fd::BorrowedFd> changed to fn pollable(&self) -> Option<Arc<dyn AsFd + '_>>

Wasmtime GitHub notifications bot (Nov 30 2022 at 05:31):

haraldh edited PR #5326 from table_immutable to main:

This patch adds interior mutability to the WasiCtx Table and the Table elements.

Major pain points:

• File only needs RwLock<cap_std::fs::File> to implement File::set_fdflags() on Windows, because of https://github.com/bytecodealliance/system-interface/blob/da238e324e752033f315f09c082ad9ce35d42696/src/fs/fd_flags.rs#L210-L217
• Because File needs a RwLock and RwLock*Guard cannot be hold across an .await, The async from async fn num_ready_bytes(&self) had to be removed
• Because File needs a RwLock and RwLock*Guard cannot be dereferenced in pollable, the signature of fn pollable(&self) -> Option<rustix::fd::BorrowedFd> changed to fn pollable(&self) -> Option<Arc<dyn AsFd + '_>>

Wasmtime GitHub notifications bot (Nov 30 2022 at 05:32):

haraldh has marked PR #5326 as ready for review.

Wasmtime GitHub notifications bot (Nov 30 2022 at 07:50):

haraldh updated PR #5326 from table_immutable to main.

Wasmtime GitHub notifications bot (Nov 30 2022 at 07:53):

haraldh updated PR #5326 from table_immutable to main.

Wasmtime GitHub notifications bot (Nov 30 2022 at 08:21):

haraldh updated PR #5326 from table_immutable to main.

Wasmtime GitHub notifications bot (Nov 30 2022 at 09:18):

haraldh submitted PR review.

Wasmtime GitHub notifications bot (Nov 30 2022 at 09:18):

haraldh created PR review comment:

@alexcrichton it's because Windows has to reopen the file with new Flags, rather than modifying the current handle. There is just no native function for this.

Wasmtime GitHub notifications bot (Nov 30 2022 at 09:19):

haraldh has marked PR #5326 as ready for review.

Last updated: Nov 22 2024 at 16:03 UTC