Wasmtime GitHub notifications bot (Nov 22 2022 at 02:56): Wasmtime GitHub notifications bot (Nov 22 2022 at 02:56):alexcrichton opened PR #5314 from fix-flaky to main:
This commit removes an assertion about the amount of time to sleep as part of the
memory.atomic.wait*instructions. We've already seen one flaky test failure due to this and I think in general the timing around it isn't super precise so it seems best to leave this specific aspect perhaps untested for now but also pretty unlikely to regress. Otherwise though testing specific sleeping timeout behavior isn't something we're well structured to test at this time.Closes #5312
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 22 2022 at 15:36):alexcrichton closed without merge PR #5314.
Last updated: Nov 22 2024 at 16:03 UTC