Stream: git-wasmtime

Topic: wasmtime / PR #5311 Refactor shared memory internals, exp...

Wasmtime GitHub notifications bot (Nov 21 2022 at 22:47):

alexcrichton opened PR #5311 from refactor-shared-memory to main:

This commit refactors the internals of wasmtime_runtime::SharedMemory a bit to expose the necessary functions to invoke from the wasmtime::SharedMemory layer. Notably some items are moved out of the RwLock from prior, such as the type and the VMMemoryDefinition. Additionally the organization around the atomic_* methods has been redone to ensure that the wasmtime-layer abstraction has a single method to call into which everything else uses as well.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 22 2022 at 08:09):

haraldh submitted PR review.

Wasmtime GitHub notifications bot (Nov 22 2022 at 16:51):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 22 2022 at 16:51):

abrown merged PR #5311.

Last updated: Nov 22 2024 at 17:03 UTC